It's never a good idea to give away plot points in a movie, but with American Sniper, the fact that he dies is of little consequence to plot or enjoyment of the movie. I think whether you see the movie knowing he dies or not knowing he dies, you will enjoy the movie the same. The vast majority of people who will see it, likely will know beforehand that he dies.